Skip to content

Updating terraform doc to add note that name of target_instance field…#17456

Merged
NickElliot merged 1 commit into
GoogleCloudPlatform:mainfrom
aditikumarii-google:doc_changes
May 13, 2026
Merged

Updating terraform doc to add note that name of target_instance field…#17456
NickElliot merged 1 commit into
GoogleCloudPlatform:mainfrom
aditikumarii-google:doc_changes

Conversation

@aditikumarii-google
Copy link
Copy Markdown
Contributor

@aditikumarii-google aditikumarii-google commented May 7, 2026 •
edited by NickElliot
Loading

@github-actions github-actions Bot requested a review from NickElliot May 7, 2026 09:46
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 7, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 487e02b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 4 insertions(+), 4 deletions(-)
google-beta provider View Diff 1 file changed, 4 insertions(+), 4 deletions(-)

NickElliot
NickElliot reviewed May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but are there plans to make these requirements enforced at plantime when breaking changes are being accepted in the next release?

@aditikumarii-google
Copy link
Copy Markdown
Contributor Author

aditikumarii-google commented May 13, 2026

LGTM but are there plans to make these requirements enforced at plantime when breaking changes are being accepted in the next release?

There are no plans to make these requirements enforced at plantime in Terraform layer. The request is expected to go to CloudSQL boss API without any previous logical modifications on Terraform.

@github-actions github-actions Bot requested a review from NickElliot May 13, 2026 04:54
@NickElliot NickElliot added this pull request to the merge queue May 13, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 27508d8 May 13, 2026
22 checks passed
This was referenced May 13, 2026
Merged
Merged
abhijeetkjha-google pushed a commit to abhijeetkjha-google/magic-modules that referenced this pull request May 13, 2026
@aditikumarii-google @abhijeetkjha-google
Updating terraform doc to add note that name of target_instance field… (
b1c8365 
GoogleCloudPlatform#17456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickElliot NickElliot NickElliot approved these changes

Assignees

No one assigned

Labels

service/sqladmin-cp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aditikumarii-google @modular-magician @NickElliot